Refactor component handling and improve user input management #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <[email protected]>
…tate is NotChecked Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
worksofliam
had a problem deploying
to
testing_environment
GitHub Actions
Failure
worksofliam
added
the
bug
worksofliam
requested review from
SanjulaGanepola and
sebjulliand
and removed request for
SanjulaGanepola
|
👋 A new build is available for this PR based on 14b2b0c. |
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
worksofliam
had a problem deploying
to
testing_environment
GitHub Actions
Failure
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
2 tasks
SanjulaGanepola
suggested changes
Feb 24, 2025
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
chrjorgensen
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
@worksofliam Code changes for Go To file tested and approved. 👍
Biggest issue during testing was that GetMbrInfo test failed - seems like the test creates a new, temp config for the host running the test? None of my connection profiles for that host uses the default temp library, so the function and the test sourcefile was not in the expected library. Something to be aware of!
|
@chrjorgensen Thanks!! odd about your tests not passing. I recommend deleting the 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enableSQLto the connection instance.NotCheckedstateNotCheckedgetMemberInfocomponent is unavailable.How to test
Try entering QSYSINC/*to filterThen tryQSYSINC/H/*` to filterMATH